Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace pr title validator #526

Merged
merged 5 commits into from
Jun 10, 2022
Merged

feat: replace pr title validator #526

merged 5 commits into from
Jun 10, 2022

Conversation

Xunzhuo
Copy link
Member

@Xunzhuo Xunzhuo commented May 2, 2022 •
edited
Loading

Signed-off-by: Xunzhuo [email protected]

resolve: #485

What this PR does:

replace pr title validator

compared with thehanimo/pr-title-checker:

amannn/action-semantic-pull-request is an ideal workflow to check PR Validation, it is followed by semantic style, as for thehanimo/pr-title-checker, we need to write the pattern in json config, and actually thery are not followed by semantic style tyle, and we have to maintain another json config, which is no-needed.

Also this project is more active than hehanimo/pr-title-checker, which means this project is more stable to be maintained. We should choose a stable and active action as our github workflow, otherwise if any bugs happened, we will get into troubles and hard for us to fix, which leads us to change our actions repeatedly, this is not what maintainers want to see.

@codecov
Copy link

codecov bot commented May 2, 2022 •
edited
Loading

Codecov Report

Merging #526 (e1f6a3f) into main (309ed3a) will not change coverage.
The diff coverage is n/a.

❗ Current head e1f6a3f differs from pull request most recent head 22d8327. Consider uploading reports for the commit 22d8327 to get more accurate results

@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9353e5...22d8327. Read the comment docs.

@Xunzhuo
Copy link
Member Author

Xunzhuo commented May 2, 2022

we need give new action: amannn/action-semantic-pull-request privilege to access resource:
image

@seeflood seeflood requested review from ZLBer and a team May 3, 2022 00:11
@Xunzhuo Xunzhuo mentioned this pull request May 3, 2022
Closed
25 tasks
@seeflood
Copy link
Member

@ZLBer Any idea on this PR?

@Xunzhuo Xunzhuo closed this Jun 3, 2022
@seeflood
Copy link
Member

seeflood commented Jun 3, 2022

@Xunzhuo Hi, why close it?
I can help authorize the action

@Xunzhuo Xunzhuo reopened this Jun 3, 2022
seeflood
seeflood approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@seeflood seeflood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood
Copy link
Member

@Xunzhuo Hi, as a poor reader, I didn't find out how to grant access to the TOKEN after reading the doc 😭
Does the action automatically get permission after being merged?

@seeflood seeflood merged commit d19465e into mosn:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeflood seeflood seeflood approved these changes

@zhenjunMa zhenjunMa zhenjunMa approved these changes

@ZLBer ZLBer Awaiting requested review from ZLBer

Assignees
No one assigned
Labels
area/community cla:yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: replace PR Title Checker with a stable action
3 participants
@Xunzhuo @seeflood @zhenjunMa